fix: migrate to non-deprecated dialog props #55799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
susnux
requested review from
nfebe and
sorbaugh
and removed request for
a team
mejo-
approved these changes
Oct 16, 2025
CarlSchwan
approved these changes
Oct 16, 2025
In Nextcloud Vue v8 some props for dialog buttons were deprecated (type for e.g. primary or nativeType) those are replaced with `variant` and `type`. In v9 the deprecated props are removed - thus this breaks with nextcloud-dialogs v7 which is based on Vue 3. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/dialog-props
branch
from
4b51216 to
470ff8d
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Nextcloud Vue v8 some props for dialog buttons were deprecated (type for e.g. primary or nativeType) those are replaced with
variantandtype.In v9 the deprecated props are removed - thus this breaks with nextcloud-dialogs v7 which is based on Vue 3.
Checklist
3. to review, feature component)stable32)