chore: Update @nextcloud/dialogs to v7.0.0
#55726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
chore/update-dialog-v7
branch
from
d31966c to
be34bbe
Compare
This is the first step torwards Vue 3. As this package is a Vue version agnostic version of dialogs, written in Vue 3. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
chore/update-dialog-v7
branch
2 times, most recently
from
29c9710 to
8ae5a8b
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
requested review from
nfebe and
szaimen
and removed request for
a team
susnux
force-pushed
the
chore/update-dialog-v7
branch
from
8ae5a8b to
cc4f830
Compare
susnux
requested review from
CarlSchwan and
artonge
and removed request for
a team
CarlSchwan
approved these changes
Oct 15, 2025
artonge
approved these changes
Oct 15, 2025
| }) | ||
|
|
||
| it('Can move a file to its parent folder', () => { | ||
| it.only('Can move a file to its parent folder', () => { |
Contributor
|
It looks like this is breaking text CI. Is it expected that file picker button is not primary anymore? 
|
Contributor
Author
|
@max-nextcloud no but that test in text is also not very good, you should not rely on class names. |
Contributor
Author
|
Fix for the primary regression: #55799 |
max-nextcloud
added a commit
that referenced
this pull request
Oct 18, 2025
In Nextcloud Vue v8 the `type` prop for dialog buttons was deprecated and replaces with the `variant` prop. In v9 the deprecated props are removed. Use the `variant` prop in the deprecated `OC.dialogs`. This is a follow up for #55726. Signed-off-by: Max <[email protected]>
6 tasks
Contributor
Author
|
/backport to stable32 |
2 tasks
susnux
pushed a commit
that referenced
this pull request
Dec 16, 2025
In Nextcloud Vue v8 the `type` prop for dialog buttons was deprecated and replaces with the `variant` prop. In v9 the deprecated props are removed. Use the `variant` prop in the deprecated `OC.dialogs`. This is a follow up for #55726. Signed-off-by: Max <[email protected]>
susnux
pushed a commit
that referenced
this pull request
Dec 17, 2025
In Nextcloud Vue v8 the `type` prop for dialog buttons was deprecated and replaces with the `variant` prop. In v9 the deprecated props are removed. Use the `variant` prop in the deprecated `OC.dialogs`. This is a follow up for #55726. Signed-off-by: Max <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first step towards Vue 3.
As this package is a Vue version agnostic version of dialogs, written in Vue 3.
The huge changes count is related to the
.licenseand.mapfiles...Checklist
3. to review, feature component)stable32)