-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
refactor(files): migrate to new NcForm* components (app settings design)
#56408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
NcForm* components (app settings design)
f18563d to
8cf8ddb
Compare
f0754f0 to
bfaf455
Compare
8cf8ddb to
a15adb1
Compare
ShGKme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder, in Vue 2 you need to add :legacy="false" to the NcAppSettingsDialog
already done |
bfaf455 to
19f60a2
Compare
artonge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
ShGKme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can approve from the new component usage side
264392c to
5f4dd0e
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
5f4dd0e to
ad0beef
Compare
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/56408/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d1b00335 82237a8b ad0beef0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56408/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Implements the new files app settings design.
Checklist
3. to review, feature component)stable32)