Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Nov 12, 2025

Summary

Implements the new files app settings design.

Checklist

@susnux susnux added this to the Nextcloud 33 milestone Nov 12, 2025
@susnux susnux added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Nov 12, 2025
@susnux susnux changed the base branch from master to refactor/files-settings November 12, 2025 18:04
@susnux susnux changed the title Refactor/files settings design refactor(files): migrate to new NcForm* components (app settings design) Nov 12, 2025
@susnux susnux force-pushed the refactor/files-settings branch from f18563d to 8cf8ddb Compare November 12, 2025 20:08
@susnux susnux force-pushed the refactor/files-settings-design branch from f0754f0 to bfaf455 Compare November 12, 2025 20:10
@susnux susnux force-pushed the refactor/files-settings branch from 8cf8ddb to a15adb1 Compare November 13, 2025 10:36
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder, in Vue 2 you need to add :legacy="false" to the NcAppSettingsDialog

Base automatically changed from refactor/files-settings to master November 13, 2025 12:35
@susnux
Copy link
Contributor Author

susnux commented Nov 13, 2025

Just a reminder, in Vue 2 you need to add :legacy="false" to the NcAppSettingsDialog

already done

@susnux susnux force-pushed the refactor/files-settings-design branch from bfaf455 to 19f60a2 Compare November 13, 2025 12:57
@susnux susnux marked this pull request as ready for review November 13, 2025 12:57
@susnux susnux requested review from a team and skjnldsv as code owners November 13, 2025 12:57
@susnux susnux requested review from artonge, nfebe and sorbaugh and removed request for a team November 13, 2025 12:57
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can approve from the new component usage side

@susnux susnux force-pushed the refactor/files-settings-design branch from 264392c to 5f4dd0e Compare November 13, 2025 22:09
@susnux susnux force-pushed the refactor/files-settings-design branch from 5f4dd0e to ad0beef Compare November 14, 2025 12:11
@sorbaugh sorbaugh merged commit b6d9364 into master Nov 14, 2025
186 of 201 checks passed
@sorbaugh sorbaugh deleted the refactor/files-settings-design branch November 14, 2025 14:13
@susnux
Copy link
Contributor Author

susnux commented Nov 14, 2025

/backport to stable32

@backportbot
Copy link

backportbot bot commented Nov 14, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/56408/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d1b00335 82237a8b ad0beef0

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56408/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request design Design, UI, UX, etc. feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files settings reorganization

5 participants