feat(files): refactor settings dialog with new form components #56437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganize settings into logical sections using NcFormBox, NcFormBoxSwitch, NcRadioGroup, and NcFormBoxButton components. Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
feat/55668/reorganize-files-settings
branch
from
3e99299 to
222e7ad
Compare
nfebe
commented
Nov 14, 2025
| v-model="userConfig.sort_favorites_first" | ||
| :label="t('files', 'Sort favorites first')" | ||
| data-cy-files-settings-setting="sort_favorites_first" | ||
| @update:modelValue="setConfig('sort_favorites_first', $event)" /> |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| @update:modelValue="setConfig('sort_favorites_first', $event)" /> | |
| @update:model-value="setConfig('sort_favorites_first', $event)" /> |
Even though I get warnings like 18:6 warning v-on event '@update:modelValue' must be hyphenated vue/v-on-event-hyphenation
The hyphenated version does not work.
kra-mo
requested changes
Nov 14, 2025
Member
kra-mo
left a comment
kra-mo
left a comment
There was a problem hiding this comment.
- The WebDAV URL should be using NcFormBoxCopyButton.
- Could Additional settings be ported to the new components? If it requires no API changes, they should be now. If it does, that should be communicated and we should eventually do it.
- Could I get screenshots of the rest of the dialog?
Contributor
|
Duplicate of #56408 ? |
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 📁 Files team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #55668
Screenshots