Skip to content

Conversation

@MorrisJobke
Copy link
Member

@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rullzer, @nickvergessen and @icewind1991 to be potential reviewers

@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Jul 26, 2016
@MorrisJobke MorrisJobke added 2. developing Work in progress 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 26, 2016
@MorrisJobke
Copy link
Member Author

https://github.com/nextcloud/files_accesscontrol <- this app then shows the UI for the workflow engine with regard to the access control rules.


return [
'routes' => [
['name' => 'flowOperations#getChecks', 'url' => '/checks', 'verb' => 'GET'], // TODO rm and do via js?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should this be done via JS? -> let's move this to another issue/PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already made a PR in #582

@nickvergessen
Copy link
Member

Tests fail Oo

PHP Fatal error: Call to a member function getUpdater() on a non-object in /drone/src/github.com/nextcloud/server/lib/private/Files/View.php on line 695

Integration tests is missing the app on the provisioning tests

@nickvergessen
Copy link
Member

Created issues for everything, lets just fix the tests here, thats the most important.

@MorrisJobke
Copy link
Member Author

Created issues for everything, lets just fix the tests here, thats the most important.

If I comment out

/**
* Test isEnabledApps() with cache, not re-reading the list of
* enabled apps more than once when a user is set.
*/
public function testEnabledAppsCache() {
$userManager = \OC::$server->getUserManager();
$user1 = $userManager->createUser(self::TEST_USER1, self::TEST_USER1);
\OC_User::setUserId(self::TEST_USER1);
$this->setupAppConfigMock()->expects($this->once())
->method('getValues')
->will($this->returnValue(
array(
'app3' => 'yes',
'app2' => 'no',
)
)
);
$apps = \OC_App::getEnabledApps();
$this->assertEquals(array('files', 'app3', 'dav', 'federatedfilesharing',), $apps);
// mock should not be called again here
$apps = \OC_App::getEnabledApps();
$this->assertEquals(array('files', 'app3', 'dav', 'federatedfilesharing',), $apps);
$this->restoreAppConfig();
\OC_User::setUserId(null);
$user1->delete();
}
all works fine 🙈

@nickvergessen
Copy link
Member

👍

@nickvergessen nickvergessen mentioned this pull request Jul 27, 2016
2 tasks
@rullzer
Copy link
Member

rullzer commented Jul 27, 2016

Fine by me if the mentioned stuff gets tackled.
LGTM

@nickvergessen nickvergessen merged commit 318d68a into master Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants