Generate the checks list in JS #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rullzer, @PVince81 and @icewind1991 to be potential reviewers |
Member
Author
nickvergessen
force-pushed
the
checks-from-js
branch
from
d5fd765 to
1b9f9a7
Compare
Member
Author
|
Rebased on after merge of #565 please review @MorrisJobke and @rullzer |
nickvergessen
force-pushed
the
checks-from-js
branch
from
1b9f9a7 to
9c6cd59
Compare
nickvergessen
force-pushed
the
checks-from-js
branch
from
9c6cd59 to
681eebc
Compare
apps/workflowengine/js/admin.js
Outdated
| }); | ||
|
|
||
| OCA.WorkflowEngine = OCA.WorkflowEngine || {}; | ||
| OCA.WorkflowEngine = OCA.WorkflowEngine || { |
Member
There was a problem hiding this comment.
This could cause issues, when another app registers this name and only assigns {}. Maybe in case the OCA.WorkflowEngine already exists we merge it (see underscore methods).
Member
Author
There was a problem hiding this comment.
So, like:
OCA.WorkflowEngine = _.extent(OCA.WorkflowEngine || {}, {
availablePlugins: [],
...
});
Member
|
Looks really nice. Once my comments are addressed I will test it :) |
Member
Author
|
Comments addressed |
| /** @var OC_L10N $l */ | ||
| ?> | ||
| <div id="workflowengine" class="section workflowengine"> | ||
| <div id="<?php p($_['appid']); ?>" class="section workflowengine"> |
Member
|
Tested and works 👍 |
Member
|
👍 |
schiessle
added
4. to release
2 tasks
R0Wi
pushed a commit
to R0Wi/server
that referenced
this pull request
Nov 22, 2025
fix(ci-action): rename CI action triage config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #574