Encode s3 metadata as base64 if needed #56515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
requested review from
salmart-dev and
yemkareems
and removed request for
a team
provokateurin
approved these changes
Nov 18, 2025
CarlSchwan
approved these changes
Nov 18, 2025
@frabe1579" This reverts commit 4b4b39e. Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
s3-meta-encode
branch
from
c8b3390 to
a7d130c
Compare
Member
Author
|
/backport to stable32 |
1 similar comment
Contributor
|
/backport to stable32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #55717 fixes the same issue by urlencoding the path (which is currently the only field that can have non-ascii characters), this introduces a more generic approach and ensures that we can reliably recover the original encoding of the path.