Skip to content

Encode s3 metadata as base64 if needed #56515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icewind1991 merged 2 commits into from
Nov 18, 2025
Merged

Encode s3 metadata as base64 if needed #56515

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8194be7
fix: encode s3 metadata as base64 if needed
icewind1991 Nov 18, 2025
a7d130c
Revert "fix(ObjectStoreStorage): Encode original-path in writeStream …
icewind1991 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "fix(ObjectStoreStorage): Encode original-path in writeStream by 
@frabe1579"

This reverts commit 4b4b39e.

Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991
icewind1991 committed Nov 18, 2025
commit a7d130c598e4f5e1034763d1c079eecbdde5cbc4
2 changes: 1 addition & 1 deletion lib/private/Files/ObjectStore/ObjectStoreStorage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ public function writeStream(string $path, $stream, ?int $size = null): int {
$metadata = [
'mimetype' => $mimetype,
'original-storage' => $this->getId(),
'original-path' => rawurlencode($path),
'original-path' => $path,
];
if ($size) {
$metadata['size'] = $size;
Expand Down
Loading