fix(federatedfilesharing): pre must not be a child of p
#57054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nfebe,
sorbaugh and
szaimen
and removed request for
a team
Contributor
Author
|
/backport to stable32 |
provokateurin
approved these changes
Jan 12, 2026
CarlSchwan
approved these changes
Jan 12, 2026
Fix the problem reported: > [plugin vite:vue] apps/federatedfilesharing/src/components/PersonalSettings.vue: <pre> cannot be child of <p>, according to HTML specifications. > This can cause hydration errors or potentially disrupt future functionality. `p` only allows inline elements, but pre is none. We either need to use `div` instead of `p` or `code` instead of `pre`. But in this case we want a block of code, so we use `div` and inner `<pre><code>`. Signed-off-by: Ferdinand Thiessen <[email protected]>
Contributor
Author
|
/compile |
susnux
force-pushed
the
fix/federated-vue
branch
from
9931315 to
29488d6
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the problem reported:
ponly allows inline elements, but pre is none.We either need to use
divinstead ofporcodeinstead ofpre. But in this case we want a block of code, so we usedivand inner<pre><code>.Checklist
3. to review, feature component)stable32)