[stable32] fix(federatedfilesharing): pre must not be a child of p
#57496
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
requested review from
CarlSchwan,
provokateurin,
susnux and
szaimen
Fix the problem reported: > [plugin vite:vue] apps/federatedfilesharing/src/components/PersonalSettings.vue: <pre> cannot be child of <p>, according to HTML specifications. > This can cause hydration errors or potentially disrupt future functionality. `p` only allows inline elements, but pre is none. We either need to use `div` instead of `p` or `code` instead of `pre`. But in this case we want a block of code, so we use `div` and inner `<pre><code>`. Signed-off-by: Ferdinand Thiessen <[email protected]> [skip ci]
provokateurin
approved these changes
Jan 12, 2026
susnux
approved these changes
Jan 12, 2026
Contributor
|
/compile |
susnux
requested review from
artonge,
nfebe and
sorbaugh
and removed request for
a team
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #57054
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.