-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Handle invalid ext storage backend to keep mount point visible #6196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @Xenopathic and @icewind1991 to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #6196 +/- ##
===========================================
+ Coverage 31.45% 37.2% +5.74%
- Complexity 21210 21217 +7
===========================================
Files 1312 1312
Lines 79291 82432 +3141
Branches 1327 1329 +2
===========================================
+ Hits 24938 30665 +5727
+ Misses 54353 51767 -2586
|
ca522b8 to
48857a2
Compare
|
@icewind1991 Updated as discussed. |
|
enhanced it to show the failed item in red in the filelist like other invalid external storages |
icewind1991
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for morris' part
|
👍 for @icewind1991's part |
Keep mount point visible and also ext storage config visible when dealing with configs relating to storage backends or auth mechanisms that were provided by an app that is currently disabled. Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
bad76e3 to
e9a58f8
Compare
Signed-off-by: Morris Jobke <[email protected]>
Keep mount point visible and also ext storage config visible when
dealing with configs relating to storage backends or auth mechanisms
that were provided by an app that is currently disabled.
Downstream of owncloud/core#26539
Separate PR because @icewind1991 commented:
To test: