Skip to content

Handle invalid ext storage backend to keep mount point visible #6196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 5 commits into from
Sep 4, 2017
Merged

Handle invalid ext storage backend to keep mount point visible #6196

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5df5b9c
Handle invalid ext storage backend to keep mount point visible
Nov 3, 2016
442d4ed
Use the FailedStorage instead
MorrisJobke Aug 29, 2017
68ee79b
set the exception for failedstorage
icewind1991 Sep 1, 2017
e9a58f8
show storage as unavailable in the file list
icewind1991 Sep 1, 2017
0326c2c
Fix broken tests
MorrisJobke Sep 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
show storage as unavailable in the file list 
Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991 @MorrisJobke
icewind1991 authored and MorrisJobke committed Sep 4, 2017
commit e9a58f857903512ba7d0d2a1078551706be906fb
3 changes: 2 additions & 1 deletion apps/files_external/lib/Lib/Backend/InvalidBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

use OCA\Files_External\Lib\Storage\InvalidStorage;
use OCA\Files_External\Lib\StorageConfig;
use OCP\Files\StorageNotAvailableException;
use OCP\IUser;

/**
Expand Down Expand Up @@ -58,7 +59,7 @@ public function getInvalidId() {
}

public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
$storage->setBackendOption('exception', new \Exception('Unknown storage backend ' . $this->invalidId));
$storage->setBackendOption('exception', new \Exception('Unknown storage backend "' . $this->invalidId . '"', StorageNotAvailableException::STATUS_ERROR));
}
}