Skip to content

Cleanup structure #9982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 11 commits into from
Jul 20, 2018
Merged

Cleanup structure #9982

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8425830
Cleanup structure
skjnldsv Jun 25, 2018
d6b7185
Sidebar fix
skjnldsv Jun 26, 2018
fe6f444
Fixed sticky controls
skjnldsv Jul 6, 2018
562e2aa
Adjust acceptance tests to sidebar changes in Files app
skjnldsv Jun 26, 2018
e27e430
use flex for main content
skjnldsv Jul 12, 2018
ecaf4d7
Fix sidebar close button
skjnldsv Jul 12, 2018
a9f6539
Widen left navigation to 300px and set max-width of right sidebar to …
jancborchardt Jul 17, 2018
43ab208
Fixed filestable min-width
skjnldsv Jul 17, 2018
8d3f58c
Jsunit fixes 1
skjnldsv Jul 17, 2018
4877cd0
Bump karma config
skjnldsv Jul 17, 2018
89ee10a
Jsunit fixes
skjnldsv Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Jsunit fixes 1 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
  • Loading branch information
@skjnldsv @MorrisJobke
skjnldsv authored and MorrisJobke committed Jul 20, 2018
commit 8d3f58c3917018a859917af377b8954910a3ba6e
7 changes: 5 additions & 2 deletions apps/files/js/detailsview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,11 @@
*/
render: function() {
// remove old instances
$('#app-sidebar').remove();
this.$el.insertAfter($('#app-content'));
if ($('#app-sidebar').length === 0) {
this.$el.insertAfter($('#app-content'));
} else {
$('#app-sidebar').replaceWith(this.$el)
}

var templateVars = {
closeLabel: t('files', 'Close')
Expand Down
2 changes: 2 additions & 0 deletions apps/files/tests/js/favoritespluginspec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ describe('OCA.Files.FavoritesPlugin tests', function() {

beforeEach(function() {
$('#testArea').append(
'<div id="content">' +
'<div id="app-navigation">' +
'<ul><li data-id="files"><a>Files</a></li>' +
'<li data-id="sharingin"><a></a></li>' +
Expand All @@ -25,6 +26,7 @@ describe('OCA.Files.FavoritesPlugin tests', function() {
'<div id="app-content-favorites" class="hidden">' +
'</div>' +
'</div>' +
'</div>' +
'</div>'
);
OC.Plugins.attach('OCA.Files.App', Plugin);
Expand Down
5 changes: 3 additions & 2 deletions apps/files/tests/js/filelistSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2491,7 +2491,8 @@ describe('OCA.Files.FileList tests', function() {

expect($('#app-sidebar').hasClass('disappear')).toEqual(false);
fileList.remove('One.txt');
expect($('#app-sidebar').hasClass('disappear')).toEqual(true);
// sidebar is removed on close before being
expect($('#app-sidebar').length).toEqual(0);
jQuery.fx.off = false;
});
it('returns the currently selected model instance when calling getModelForFile', function() {
Expand All @@ -2515,7 +2516,7 @@ describe('OCA.Files.FileList tests', function() {

expect($('#app-sidebar').hasClass('disappear')).toEqual(false);
fileList.changeDirectory('/another');
expect($('#app-sidebar').hasClass('disappear')).toEqual(true);
expect($('#app-sidebar').length).toEqual(0);
jQuery.fx.off = false;
});
});
Expand Down
4 changes: 2 additions & 2 deletions core/js/tests/specs/appsSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
describe('Apps base tests', function() {
describe('Sidebar utility functions', function() {
beforeEach(function() {
$('#testArea').append('<div id="app-content">Content</div><div id="app-sidebar">The sidebar</div>');
$('#testArea').append('<div id="content"><div id="app-content">Content</div><div id="app-sidebar">The sidebar</div></div>');
jQuery.fx.off = true;
});
afterEach(function() {
Expand All @@ -41,7 +41,7 @@ describe('Apps base tests', function() {
});
it('triggers appresize event when visibility changed', function() {
var eventStub = sinon.stub();
$('#app-content').on('appresized', eventStub);
$('#content').on('appresized', eventStub);
OC.Apps.showAppSidebar();
expect(eventStub.calledOnce).toEqual(true);
OC.Apps.hideAppSidebar();
Expand Down