Skip to content

Cleanup structure #9982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 11 commits into from
Jul 20, 2018
Merged

Cleanup structure #9982

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8425830
Cleanup structure
skjnldsv Jun 25, 2018
d6b7185
Sidebar fix
skjnldsv Jun 26, 2018
fe6f444
Fixed sticky controls
skjnldsv Jul 6, 2018
562e2aa
Adjust acceptance tests to sidebar changes in Files app
skjnldsv Jun 26, 2018
e27e430
use flex for main content
skjnldsv Jul 12, 2018
ecaf4d7
Fix sidebar close button
skjnldsv Jul 12, 2018
a9f6539
Widen left navigation to 300px and set max-width of right sidebar to …
jancborchardt Jul 17, 2018
43ab208
Fixed filestable min-width
skjnldsv Jul 17, 2018
8d3f58c
Jsunit fixes 1
skjnldsv Jul 17, 2018
4877cd0
Bump karma config
skjnldsv Jul 17, 2018
89ee10a
Jsunit fixes
skjnldsv Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed sticky controls 
since controls are not directly into the scollable element (app-content)
we need to make the parent the scrollable element (app-content-files)

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
  • Loading branch information
@skjnldsv @MorrisJobke
skjnldsv authored and MorrisJobke committed Jul 20, 2018
commit fe6f444928bd9b1f4dd2df82ef8ee7fb2b40aa5d
4 changes: 4 additions & 0 deletions apps/files/css/files.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@
min-height: 0%;
}

#app-content > [id^='app-content-'] {
max-height: calc(100vh - $header-height);
}

.app-files #app-content {
transition: background-color 0.3s ease;
overflow-x: hidden;
Expand Down