Parsing ifconfig output for system info in FreeBSD logs error

[oblomow]

Steps to reproduce

1. log in to nextcloud and request 'system info' (on system with two networkinterfaces)
2. go to logging (in nextcloud webportal)

Expected behaviour

no error should appear in the logging

Actual behaviour

it shows: Error: Undefined offset: 0 at /usr/local/www/owncloud/apps/serverinfo/lib/OperatingSystems/FreeBSD.php#187

the result of parsing this output wrong:
ifconfig | grep base
media: Ethernet autoselect (1000baseT )
media: Ethernet autoselect (1000baseT )

Server configuration

Operating system: FreeBSD 12.2-RELEASE-p1

Web server: hiawatha-10.11

Database: mysql80-server-8.0.22_1

PHP version: PHP 7.4.14

Nextcloud version: 20.0.6

Where did you install Nextcloud from:

List of activated apps:

Enabled:

• accessibility: 1.6.0
• activity: 2.13.4
• admin_audit: 1.10.0
• bruteforcesettings: 2.0.1
• calendar: 2.1.3
• cloud_federation_api: 1.3.0
• contacts: 3.4.3
• contactsinteraction: 1.1.0
• dav: 1.16.2
• external: 3.7.2
• federatedfilesharing: 1.10.2
• federation: 1.10.1
• files: 1.15.0
• files_pdfviewer: 2.0.1
• files_rightclick: 0.17.0
• files_sharing: 1.12.2
• files_trashbin: 1.10.1
• files_versions: 1.13.0
• files_videoplayer: 1.9.0
• firstrunwizard: 2.9.0
• forms: 2.1.0
• logreader: 2.5.0
• lookup_server_connector: 1.8.0
• mail: 1.8.0
• nextcloud_announcements: 1.9.0
• notifications: 2.8.0
• oauth2: 1.8.0
• password_policy: 1.10.1
• privacy: 1.4.0
• provisioning_api: 1.10.0
• recommendations: 0.8.0
• serverinfo: 1.10.0
• settings: 1.2.0
• sharebymail: 1.10.0
• support: 1.3.0
• survey_client: 1.8.0
• systemtags: 1.10.0
• text: 3.1.0
• theming: 1.11.0
• twofactor_backupcodes: 1.9.0
• updatenotification: 1.10.0
• user_status: 1.0.1
• viewer: 1.4.0
• weather_status: 1.0.0
• workflowengine: 2.2.0
  Disabled:
• announcementcenter
• comments
• dashboard
• encryption
• files_external
• files_trackdownloads
• photos
• user_ldap

Nextcloud configuration:

{
"system": {
"instanceid": "REMOVED SENSITIVE VALUE",
"passwordsalt": "REMOVED SENSITIVE VALUE",
"trusted_domains": [
"cloud.bospaling.nl"
],
"debug": false,
"log_type": "file",
"datadirectory": "REMOVED SENSITIVE VALUE",
"dbtype": "mysql",
"version": "20.0.6.1",
"installed": true,
"check_for_working_webdav": false,
"loglevel": 2,
"theme": "",
"maintenance": false,
"secret": "REMOVED SENSITIVE VALUE",
"mail_from_address": "REMOVED SENSITIVE VALUE",
"mail_smtpmode": "smtp",
"mail_domain": "REMOVED SENSITIVE VALUE",
"forcessl": true,
"mail_smtpsecure": "tls",
"trashbin_retention_obligation": "auto",
"appstoreenabled": true,
"appstore.experimental.enabled": true,
"enable_avatars": false,
"updatechecker": true,
"mail_smtpauthtype": "LOGIN",
"mail_smtphost": "REMOVED SENSITIVE VALUE",
"mail_smtpport": "25",
"mail_smtpauth": 1,
"mail_smtpname": "REMOVED SENSITIVE VALUE",
"mail_smtppassword": "REMOVED SENSITIVE VALUE",
"overwrite.cli.url": "https://cloud.bospaling.nl",
"dbname": "REMOVED SENSITIVE VALUE",
"dbhost": "REMOVED SENSITIVE VALUE",
"dbuser": "REMOVED SENSITIVE VALUE",
"dbpassword": "REMOVED SENSITIVE VALUE",
"updater.release.channel": "stable",
"mysql.utf8mb4": true,
"memcache.local": "\OC\Memcache\Redis",
"app_install_overwrite": [
"calendar",
"admin_notifications",
"contacts"
],
"encryption.legacy_format_support": false,
"encryption.key_storage_migrated": false,
"defaultapp": "files",
"redis": {
"host": "REMOVED SENSITIVE VALUE",
"port": 0,
"timeout": 1.5
},
"updater.secret": "REMOVED SENSITIVE VALUE"
}
}

Client configuration

error occurs from multiple os/browser combinations.

Logs

Error: Undefined offset: 0 at /usr/local/www/owncloud/apps/serverinfo/lib/OperatingSystems/FreeBSD.php#187

/usr/local/www/owncloud/apps/serverinfo/lib/OperatingSystems/FreeBSD.php - line 187:

OC\Log\ErrorHandler::onError(8, "Undefined offset: 0", "/usr/local/ ... p", 187, { 0: "And 7 ... }})

/usr/local/www/owncloud/apps/serverinfo/lib/Os.php - line 132:

OCA\ServerInfo\OperatingSystems\FreeBSD->getNetworkInterfaces()

/usr/local/www/owncloud/apps/serverinfo/lib/Settings/AdminSettings.php - line 111:

OCA\ServerInfo\Os->getNetworkInterfaces()

/usr/local/www/owncloud/apps/settings/lib/Controller/CommonSettingsTrait.php - line 141:

OCA\ServerInfo\Settings\AdminSettings->getForm()

/usr/local/www/owncloud/apps/settings/lib/Controller/AdminSettingsController.php - line 83:

OCA\Settings\Controller\AdminSettingsController->formatSettings([ [ OCA\Serv ... ]])

/usr/local/www/owncloud/apps/settings/lib/Controller/CommonSettingsTrait.php - line 152:

OCA\Settings\Controller\AdminSettingsController->getSettings("serverinfo")

/usr/local/www/owncloud/apps/settings/lib/Controller/AdminSettingsController.php - line 68:

OCA\Settings\Controller\AdminSettingsController->getIndexResponse("admin", "serverinfo")

/usr/local/www/owncloud/lib/private/AppFramework/Http/Dispatcher.php - line 169:

OCA\Settings\Controller\AdminSettingsController->index("serverinfo")

/usr/local/www/owncloud/lib/private/AppFramework/Http/Dispatcher.php - line 100:

OC\AppFramework\Http\Dispatcher->executeController(OCA\Settings ... {}, "index")

/usr/local/www/owncloud/lib/private/AppFramework/App.php - line 152:

OC\AppFramework\Http\Dispatcher->dispatch(OCA\Settings ... {}, "index")

/usr/local/www/owncloud/lib/private/Route/Router.php - line 309:

OC\AppFramework\App::main("OCA\\Settin ... r", "index", OC\AppFramew ... {}, { section: " ... "})

/usr/local/www/owncloud/lib/base.php - line 1008:

OC\Route\Router->match("/settings/admin/serverinfo")

/usr/local/www/owncloud/index.php - line 37:

OC::handleRequest()

Nextcloud log (data/owncloud.log)

Insert your Nextcloud log here

[VVD]

/usr/local/www/owncloud/

not nextcloud?

My 187th line is: $iface['speed'] = $speed[0];

Can you show ifconfig -a?

[oblomow]

the directory name /usr/local/www/owncloud is a remnant from the past. I started using owncloud, then switched to nextcloud. This was some years ago.

My 187th line is also: $iface['speed'] = $speed[0];

ifconfig -a

`re0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
options=8209b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,WOL_MAGIC,LINKSTATE>
ether 18:c0:4d:46:76:67
inet 192.168.2.3 netmask 0xffffff00 broadcast 192.168.2.255
media: Ethernet autoselect (1000baseT )
status: active
nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>
em0: flags=8943<UP,BROADCAST,RUNNING,PROMISC,SIMPLEX,MULTICAST> metric 0 mtu 1500
options=812099<RXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,WOL_MAGIC,VLAN_HWFILTER>
ether 00:1b:21:c8:3f:9e
inet 192.168.0.1 netmask 0xffffff00 broadcast 192.168.0.255
inet 192.168.54.2 netmask 0xffffff00 broadcast 192.168.54.255
media: Ethernet autoselect (1000baseT )
status: active
nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>
lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> metric 0 mtu 16384
options=680003<RXCSUM,TXCSUM,LINKSTATE,RXCSUM_IPV6,TXCSUM_IPV6>
inet6 ::1 prefixlen 128
inet6 fe80::1%lo0 prefixlen 64 scopeid 0x3
inet 127.0.0.1 netmask 0xff000000
groups: lo
nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
pflog0: flags=141<UP,RUNNING,PROMISC> metric 0 mtu 33160
groups: pflog
tun0: flags=8051<UP,POINTOPOINT,RUNNING,MULTICAST> metric 0 mtu 1500
options=80000
inet6 fe80::1ac0:4dff:fe46:7667%tun0 prefixlen 64 scopeid 0x5
inet 10.8.0.1 --> 10.8.0.2 netmask 0xffffffff
groups: tun
nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
Opened by PID 2284
em0bridge: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
ether 02:a2:4b:5d:8c:00
id 00:00:00:00:00:00 priority 32768 hellotime 2 fwddelay 15
maxage 20 holdcnt 6 proto stp-rstp maxaddr 2000 timeout 1200
root id 00:00:00:00:00:00 priority 32768 ifcost 0 port 0
member: e0a_demojail flags=143<LEARNING,DISCOVER,AUTOEDGE,AUTOPTP>
ifmaxaddr 0 port 7 priority 128 path cost 2000
member: em0 flags=143<LEARNING,DISCOVER,AUTOEDGE,AUTOPTP>
ifmaxaddr 0 port 2 priority 128 path cost 20000
groups: bridge
nd6 options=9<PERFORMNUD,IFDISABLED>
e0a_demojail: flags=8943<UP,BROADCAST,RUNNING,PROMISC,SIMPLEX,MULTICAST> metric 0 mtu 1500
options=8<VLAN_MTU>
ether 02:b4:d2:c8:3f:9e
hwaddr 02:3b:76:e5:50:0a
groups: epair
media: Ethernet 10Gbase-T (10Gbase-T )
status: active
nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>

`

[oblomow]

error still present in FreeBSD13 in combination with nextcloud 21.0.1

`Error: Undefined offset: 0 at /usr/local/www/owncloud/apps/serverinfo/lib/OperatingSystems/FreeBSD.php#171

/usr/local/www/owncloud/apps/serverinfo/lib/OperatingSystems/FreeBSD.php - line 171:

OC\Log\ErrorHandler::onError(8, "Undefined offset: 0", "/usr/local/ ... p", 171, { 0: "And 7 ... }})

/usr/local/www/owncloud/apps/serverinfo/lib/Os.php - line 124:

OCA\ServerInfo\OperatingSystems\FreeBSD->getNetworkInterfaces()

/usr/local/www/owncloud/apps/serverinfo/lib/Settings/AdminSettings.php - line 111:

OCA\ServerInfo\Os->getNetworkInterfaces()

/usr/local/www/owncloud/apps/settings/lib/Controller/CommonSettingsTrait.php - line 138:

OCA\ServerInfo\Settings\AdminSettings->getForm()

/usr/local/www/owncloud/apps/settings/lib/Controller/AdminSettingsController.php - line 83:

OCA\Settings\Controller\AdminSettingsController->formatSettings([ [ OCA\Serv ... ]])

/usr/local/www/owncloud/apps/settings/lib/Controller/CommonSettingsTrait.php - line 149:

OCA\Settings\Controller\AdminSettingsController->getSettings("serverinfo")

/usr/local/www/owncloud/apps/settings/lib/Controller/AdminSettingsController.php - line 68:

OCA\Settings\Controller\AdminSettingsController->getIndexResponse("admin", "serverinfo")

/usr/local/www/owncloud/lib/private/AppFramework/Http/Dispatcher.php - line 218:

OCA\Settings\Controller\AdminSettingsController->index("serverinfo")

/usr/local/www/owncloud/lib/private/AppFramework/Http/Dispatcher.php - line 127:

OC\AppFramework\Http\Dispatcher->executeController(OCA\Settings ... {}, "index")

/usr/local/www/owncloud/lib/private/AppFramework/App.php - line 157:

OC\AppFramework\Http\Dispatcher->dispatch(OCA\Settings ... {}, "index")

/usr/local/www/owncloud/lib/private/Route/Router.php - line 302:

OC\AppFramework\App::main("OCA\\Settin ... r", "index", OC\AppFramew ... {}, { section: " ... "})

/usr/local/www/owncloud/lib/base.php - line 993:

OC\Route\Router->match("/settings/admin/serverinfo")

/usr/local/www/owncloud/index.php - line 37:

OC::handleRequest()`

[oblomow]

and still in 21.0.2

[hadret]

Can confirm it still occurs in 21.0.2 on FreeBSD 13.0. there are two lines that it complains in particular in the file ...nextcloud/apps/serverinfo/lib/OperatingSystems/FreeBSD.php:

[...]
139    $result['gateway'] = $gw[0];
[...]
171    $iface['speed']  = $speed[0];
[...]

The error message looks very similar to what was fixed with PR #251. I tried to mitigate it like so:

[...]
139                         /* $result['gateway'] = $gw[0]; */
140                         if (isset($gw[0])) {
141                                 $result['gateway'] = $gw[0];
142                         }
[...]

[...]
174                                 /* $iface['speed']  = $speed[0]; */
175
176                                 if (isset($speed[0])) {
177                                         $iface['speed'] = $speed[0];
178                                 }
[...]

Let's see how it goes 🤷🏻‍♂️

[oblomow]

This seems to do the trick. The error message in the logs is gone when I request serverinfo

[oblomow]

still in 21.0.3

[oblomow]

no change in 21.0.4

[oblomow]

no change in 21.0.5

[oblomow]

no change in 22.2.0

[oblomow]

and unfortunately in 22.2.1

  Error: Undefined offset: 0 at /usr/local/www/owncloud/apps/serverinfo/lib/OperatingSystems/FreeBSD.php#183

[oblomow]

and 22.2.2

[oblomow]

22.2.3...
The changes mentioned above seem to work, but I don't feel comfortable submitting the source code in github.