Fix FreeBsd Interface parsing #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KDederichs
changed the title
…d or mac Signed-off-by: Kai Dederichs <[email protected]>
Signed-off-by: Kai Dederichs <[email protected]>
kesselb
approved these changes
May 11, 2022
Collaborator
kesselb
left a comment
kesselb
left a comment
There was a problem hiding this comment.
Thank you very much 🥳
LGTM.
Logic to hide/show elements is a bit confusing. For mac we have a check in settings-template.php to show the mac when available. For speed there is a another block in FreeBSD.php with some defaults when the data is unavailable.
come-nc
approved these changes
May 12, 2022
Contributor
|
/backport to stable24 |
Contributor
|
/backport to stable23 |
Contributor
|
/backport to stable22 |
8 tasks
Contributor
Author
|
/backport to stable23 |
Contributor
Author
|
/backport to stable22 |
Contributor
Author
|
Guess it ate them the first time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #270