-
Notifications
You must be signed in to change notification settings - Fork 64
[stable23] Fix FreeBsd Interface parsing #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ok, it ate the changes to lib/OperatingSystems/FreeBSD.php no clue how to fix that :) |
check out this branch and commit and push fixes to it. |
|
I have no write permission here so that's a bit difficult.... |
Ah! Okay, you've been invited :) |
|
/rebase |
|
Yeah not sure how to best get it to do that check.... Github is weird that way.... |
Can you rebase your branch to stable23? This should get the latest changes in and hopefully trigger a CI re run. |
|
@kesselb I mean I can, but it's not really my branch anyways since the backport bot opened it so who ever wants to do it, it's fine by me :) |
|
Alas it'd be neat if someone did it, I rarely rebase stuff and before I break something I'd rather someone else do it |
…d or mac Signed-off-by: Kai Dederichs <[email protected]> Make test throw when requesting a non-valid interface Signed-off-by: Kai Dederichs <[email protected]> Backport FreeBSD.php to stable23 Signed-off-by: Kai Dederichs <[email protected]> Fix CS Signed-off-by: Kai Dederichs <[email protected]>
46353b8 to
fb73c95
Compare
|
@KDederichs done. All changes are there? ;) |
|
Looking good yeah, but I guess that one is still not running? Or does it depend on the PHPUnit one? |
backport of #372