Add collaborator plugin for rooms #1051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
requested review from
MorrisJobke,
nickvergessen,
rullzer and
schiessle
|
|
||
| <collaboration> | ||
| <plugins> | ||
| <plugin type="collaborator-search" share-type="SHARE_TYPE_ROOM">OCA\Spreed\Collaboration\Collaborators\RoomPlugin</plugin> |
Member
There was a problem hiding this comment.
Apart from the name this PR looks good
danxuliu
force-pushed
the
add-support-for-room-shares
branch
2 times, most recently
from
9d32bfa to
d2872a9
Compare
danxuliu
force-pushed
the
add-support-for-room-shares
branch
from
be6e15a to
370728b
Compare
danxuliu
force-pushed
the
add-collaborator-plugin-for-rooms
branch
from
7093937 to
1b7f4ca
Compare
schiessle
approved these changes
Aug 8, 2018
Member
schiessle
left a comment
schiessle
left a comment
There was a problem hiding this comment.
tested and works as expected
danxuliu
force-pushed
the
add-collaborator-plugin-for-rooms
branch
from
1b7f4ca to
8cb5298
Compare
nickvergessen
force-pushed
the
add-support-for-room-shares
branch
from
7ecb121 to
57bf6e6
Compare
A user can create a room share only with rooms in which she is a participant. Therefore the search is limited to those rooms. Currently the rooms are searched only by their name; it is not possible yet to search them based on other participants. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
nickvergessen
force-pushed
the
add-collaborator-plugin-for-rooms
branch
from
8cb5298 to
178cad4
Compare
nickvergessen
changed the base branch from
add-support-for-room-shares
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #1050 (this pull request should be rebased onto master once #1050 is merged)