Add unit tests for collaborator search #1220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
added
3. to review
backport-request
feature: upload & shares & voice 📤🎙️
| $password = ''; | ||
| $activeGuests = 0; | ||
|
|
||
| return new Room($manager, $db, $secureRandom, $dispatcher, $hasher, $id, $type, $token, $name, $password, $activeGuests); |
Member
There was a problem hiding this comment.
could also do $this->createMock(Room::class); and then mock the methods you actually test?
Member
Author
There was a problem hiding this comment.
Good point, done; I kept the room type as a parameter even if it is not actually used because it looks like something that should be included in the result, so less typing in the tests for the future :-P
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
add-unit-tests-for-collaborator-search
branch
from
99c023c to
780bcf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to commit this in #1051 🤦