Skip to content

Conversation

@provokateurin
Copy link
Member

☑️ Resolves

'size' => $size,
is always the result of $node->getSize() and therefore an integer.

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@provokateurin
Copy link
Member Author

Again, I don't know how important this fix is so please decide yourself if a backport is necessary.

@nickvergessen
Copy link
Member

Im not sure. I think we should cast it to string. Because it is actually float or integer iirc.
And all parameters should be strings as per the definition 🙈
https://github.com/nextcloud/server/blob/master/lib/public/RichObjectStrings/Definitions.php#L337

@provokateurin
Copy link
Member Author

I interpreted the example to be wrong and it should be an integer instead. I guess either way is possible, we just need to know how it was originally intended.
The other thing is the float type which I honestly don't understand. Is this a fix to avoid overflows on 32-bit systems by using double values?

@provokateurin provokateurin deleted the fix/openapi/rich-object-size-integer branch April 6, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants