fix: Set all rich object parameter values to string #12021
Merged
+25
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/rich-object-non-string-values
branch
from
a64826e to
338e811
Compare
nickvergessen
requested changes
Apr 7, 2024
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
PS: requires review from all requested persons
So blocking until everyone else approved
…nents Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
approved these changes
Apr 8, 2024
DorraJaouad
approved these changes
Apr 8, 2024
nickvergessen
added
feature: chat 💬
This was referenced Apr 10, 2024
|
all fine for android talk as well, @nickvergessen |
Antreesy
added a commit
that referenced
this pull request
Apr 18, 2024
- in #12021 type of server response was changed to strings, forget to cover tests - Element.scrollTo is not implemented in JSDOM, need to mock it to avoid errors in Jest Signed-off-by: Maksim Sukharev <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
- in #12021 type of server response was changed to strings, forget to cover tests - Element.scrollTo is not implemented in JSDOM, need to mock it to avoid errors in Jest Signed-off-by: Maksim Sukharev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Replaces #11991.
Only strings are allowed as values.
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required