Skip to content

Conversation

@Antreesy
Copy link
Contributor

☑️ Resolves

- in #12021 type of server response was changed to strings, forget to cover tests
- Element.scrollTo is not implemented in JSDOM, need to mock it to avoid errors in Jest

Signed-off-by: Maksim Sukharev <[email protected]>
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks clean

@nickvergessen nickvergessen merged commit 2956e52 into main Apr 18, 2024
@nickvergessen nickvergessen deleted the fix/12021/cleanup-jest branch April 18, 2024 08:43
@nickvergessen
Copy link
Member

Backport?

@DorraJaouad
Copy link
Contributor

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants