Removed the background job and checks #12496
Conversation
| } | ||
|
|
||
| if ($this->serverConfig->getAppValue('spreed', 'has_reference_id', 'no') === 'yes') { | ||
| $capabilities['features'][] = 'chat-reference-id'; |
There was a problem hiding this comment.
The capability needs to be always on, so add it to the hardcoded feature list 🤔
There was a problem hiding this comment.
Now after thinking about it, maybe we should adjust the docs in
Line 52 in fb8a73c
skalidindi53
force-pushed
the
skalidindi53/12428/Remove-reference_id-check
branch
4 times, most recently
from
ba0521c to
217557f
Compare
Signed-off-by: skalidindi53 <[email protected]>
skalidindi53
force-pushed
the
skalidindi53/12428/Remove-reference_id-check
branch
from
217557f to
b5ab57e
Compare
|
@skalidindi53 Failing tests are fixed in #12506. If you rebase on latest main, you should have green CI here :) |
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Looks good otherwise, just needs a rebase for CI
Signed-off-by: skalidindi53 <[email protected]>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
☑️ Resolves
reference_idcheck #12428🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required