-
Notifications
You must be signed in to change notification settings - Fork 509
🤖 Commands #1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 Commands #1453
Conversation
94c3f41 to
afb387c
Compare
99b4c3c to
b028501
Compare
@danxuliu I had a look at this. The biggest problem is, that it would require all clients to understand HTML or any other markup we add/support there. So for version 1 I would go with plaintext only (also note that we have a 1k char limit atm). We can still go for a output-markup later on. |
6409144 to
2922d5f
Compare
|
@skjnldsv when you are back again, can you help turning the admin overview of commands into a nice grid layout similar to the user management. That would be very cool 😎 |
e8c924b to
a59db2e
Compare
|
Ready for review, UI hint and finishing will go in a new PR |
of course! Follow-up pr ? |
yes, much appriciated |
87507c3 to
58aacf2
Compare
Ivansss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing: Rendering correctly bot messages that are not for the current user.
please ping me once merged, I'll address this :) |
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
It's just too dangerous for now. Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
58aacf2 to
2f60aab
Compare
Now done, please re-review @Ivansss |
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
|
@skjnldsv it's in :) |
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
…om-1453 Fix unit tests from #1453
This is a first step towards the option to allow writing bots.
/calculate 42+23Fix #1179
Tasks
/helpinto the input)Calc example
./occ talk:command:add calc calculator "/path/to/calc.sh \"{ARGUMENTS_DOUBLEQUOTE_ESCAPED}\"" 1 3calc.sh:
Echo example
./occ talk:command:add echo reflection "/path/to/echo.sh \"{ARGUMENTS_DOUBLEQUOTE_ESCAPED}\"" 1 3echo.sh: