Skip to content

Fix missing guest names in chat #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ivansss merged 1 commit into from
Feb 25, 2019
Merged

Fix missing guest names in chat #1573

Ivansss merged 1 commit into from
Feb 25, 2019

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 21, 2019

  • As a guest set a name
  • Post a message
  • Expect that the message shows as "Your name"

Regression from #1453

@nickvergessen
Fix missing guest names in chat
5551134 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added this to the 💚 Next Major milestone Feb 21, 2019
Ivansss
Ivansss approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@Ivansss Ivansss merged commit 6fb7878 into master Feb 25, 2019
@Ivansss Ivansss deleted the bugfix/noid/fix-missing-guest-names branch February 25, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ivansss Ivansss Ivansss approved these changes

Assignees

No one assigned

Labels

3. to review bug feature: chat 💬 Chat and system messages regression

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @Ivansss