Skip to content

Allow to restrict to group #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 11 commits into from
Mar 4, 2019
Merged

Allow to restrict to group #1585

nickvergessen merged 11 commits into from
Mar 4, 2019

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 26, 2019 •
edited
Loading

Questions:

  • Remove from all rooms including a "leave"-message
  • What to do with one-to-one conversations, where leaving means it's deleted for both.
  • Remove all activity

@nickvergessen nickvergessen added this to the 💚 Next Major milestone Feb 26, 2019
@nickvergessen nickvergessen force-pushed the feature/1105/allow-to-restrict-to-group branch 2 times, most recently from e24ed69 to a6a63d5 Compare February 28, 2019 10:14
@nickvergessen nickvergessen marked this pull request as ready for review February 28, 2019 10:14
@nickvergessen nickvergessen force-pushed the feature/1105/allow-to-restrict-to-group branch 2 times, most recently from 85891a2 to 49e610b Compare February 28, 2019 14:51
@nickvergessen
Add config method to check if the user can access Talk
551289a 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Filter out users and groups that can not access Talk
4aab4e5 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Register the navigation via Application so we can silence it if needed
576ecfc 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Redirect people to the main app
b0f7b7c 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Remove notifications for the user
0e0a66a 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Hide activities for users who can not Talk
5b5dfee 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Remove capabilities for the mobile clients
5605e9c 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add an admin setting to restrict the app to groups
b2db37f 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the feature/1105/allow-to-restrict-to-group branch from 49e610b to 11d7581 Compare March 1, 2019 09:04
@nickvergessen nickvergessen force-pushed the feature/1105/allow-to-restrict-to-group branch from 11d7581 to a2fc199 Compare March 1, 2019 10:02
@nickvergessen nickvergessen mentioned this pull request Mar 1, 2019
Merged
1 task
Ivansss
Ivansss reviewed Mar 4, 2019
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add some indicator (green tick) when changes are saved. At the moment it looks like the "Save changes" button does nothing.

@nickvergessen
Copy link
Member Author

nickvergessen commented Mar 4, 2019

I added a change of the button text as feedback

Ivansss
Ivansss approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@Ivansss Ivansss mentioned this pull request Mar 4, 2019
Merged
@nickvergessen nickvergessen merged commit c387044 into master Mar 4, 2019
@nickvergessen nickvergessen deleted the feature/1105/allow-to-restrict-to-group branch March 4, 2019 14:24
@nickvergessen nickvergessen mentioned this pull request Mar 22, 2019
Merged
3 tasks
@nickvergessen nickvergessen mentioned this pull request Apr 10, 2019
Merged
4 tasks
@nickvergessen nickvergessen mentioned this pull request May 2, 2019
Closed
@wdfee wdfee mentioned this pull request Jul 18, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ivansss Ivansss Ivansss approved these changes

Assignees

No one assigned

Labels

3. to review enhancement

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @Ivansss