Persistent one-to-one rooms

[nickvergessen]

• Based on Allow to restrict to group #1585

The idea is to make one-to-one rooms persistent:

• No more guests allowed
• You can not add people to it
• You can only leave it, not delete it

If the second user:

• leaves: the room is deleted
• posts a chat message: participant 1 is readded
• starts a call: participant 1 is readded

This prevents misunderstandings like #1528 and is also more in line with the behaviour of other messengers.

[nickvergessen]

@Ivansss @mario There is a new capability locked-one-to-one with a good explanation in docs/apiv1.md: https://github.com/nextcloud/spreed/pull/1591/files#diff-c64b0a0d2d21bf78e238ccb4d50fc0e6

[danxuliu]

Moderators can no longer leave a public room in which they are the only participants; see https://drone.nextcloud.com/nextcloud/spreed/1684/56 Is that on purpose?

Besides that, I will take care of the acceptance tests.

[nickvergessen]

Moderators can no longer leave a public room in which they are the only participants; see https://drone.nextcloud.com/nextcloud/spreed/1684/56 Is that on purpose?

That is from #1588 but yeah I will fix it here

Besides that, I will take care of the acceptance tests.

No, I will do this.

[danxuliu]

Moderators can no longer leave a public room in which they are the only participants; see https://drone.nextcloud.com/nextcloud/spreed/1684/56 Is that on purpose?

That is from #1588 but yeah I will fix it here

I think that it was broken in this pull request; in #1588 they worked fine (the remove tests; the sharees tests yes, I think that they were broken in #1588).

Besides that, I will take care of the acceptance tests.

No, I will do this.

OK, but keep in mind:

• Failure in room-shares is unrelated; it seems to be a race condition or something like that
• Failure in conversation:82 is legit; the empty content view is fixed in Fix empty content message when leaving a room #1594
• Failure in conversation:57 can not be properly fixed until Fix empty content message when leaving a room #1594 is in, because once it is fixed for the changes in this pull request it will still fail until Fix empty content message when leaving a room #1594 is merged

[nickvergessen]

• Failure in room-shares is unrelated; it seems to be a race condition or something like that

OK

• Failure in conversation:82 is legit; the empty content view is fixed in Fix empty content message when leaving a room #1594

Ah, I didnt get how that one happens :P

• Failure in conversation:57 can not be properly fixed until Fix empty content message when leaving a room #1594 is in, because once it is fixed for the changes in this pull request it will still fail until Fix empty content message when leaving a room #1594 is merged

Yes it can, I fixed it.

[danxuliu]

Failure in conversation:57 can not be properly fixed until #1594 is in, because once it is fixed for the changes in this pull request it will still fail until #1594 is merged

Yes it can, I fixed it.

OK, wrong wording on my part; I meant that even if properly fixed the test will not pass until #1594 is merged and this pull request rebased.