Fix empty content message when leaving a room #1594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, deleting a room and removing oneself from a room had the same behaviour: if the room was the active one it was first left and, then, the room was destroyed. However, while that still happens when deleting a room, when removing oneself from a room now the room is first destroyed and, then, the room is left; as destroying the room can be rejected by the server it is necessary to wait until the room is destroyed to leave it and update the UI accordingly. The empty content view expected that a room was always left before being destroyed, so the change in the order of events caused that when the room was destroyed the initial message was set, but when it was then left the initial message was overwritten with the conversation ended message; now the conversation ended messsage is set only if the room was not destroyed before it is left, which fixes the wrong behaviour when removing oneself from a room without affecting the behaviour when rooms are destroyed or the user is removed by a moderator from a room. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Member
Is that related? |
Ivansss
approved these changes
Mar 1, 2019
Member
Author
It passes when run in local, so it looks like a hiccup/race condition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1588
Before, deleting a room and removing oneself from a room had the same behaviour: if the room was the active one it was first left and, then, the room was destroyed. However, while that still happens when deleting a room, when removing oneself from a room now the room is first destroyed and, then, the room is left; as destroying the room can be rejected by the server it is necessary to wait until the room is destroyed to leave it and update the UI accordingly.
The empty content view expected that a room was always left before being destroyed, so the change in the order of events caused that when the room was destroyed the initial message was set, but when it was then left the initial message was overwritten with the conversation ended message; now the conversation ended messsage is set only if the room was not destroyed before it is left, which fixes the wrong behaviour when removing oneself from a room without affecting the behaviour when rooms are destroyed or the user is removed by a moderator from a room.