Keep last visible message when new message field height changes #1953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new message field is below the message list, so adding or removing lines from the message being composed changes the height of the new message field and, with it, the height of the message list. This change, however, did not affect the scroll position of the message list, so adding lines to the new message field caused it to overlap the last visible message in the list. Now the height change in the new message field is handled to update the scroll position of the message list and keep the last visible message at the bottom (both when lines are added and removed from the new message field). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: chat 💬
Member
Author
|
/backport to stable16 |
marcoambrosini
approved these changes
Jul 4, 2019
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
Tested and works as expected! Very well commented, thanks :)
delete-merged-branch
bot
deleted the
keep-last-visible-message-when-new-message-field-height-changes
branch
|
backport to stable16 in #1955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1950
Fixes #1938
The new message field is below the message list, so adding or removing lines from the message being composed changes the height of the new message field and, with it, the height of the message list. This change, however, did not affect the scroll position of the message list, so adding lines to the new message field caused it to overlap the last visible message in the list. Now the height change in the new message field is handled to update the scroll position of the message list and keep the last visible message at the bottom (both when lines are added and removed from the new message field).