Fix chat jumping back when typing a new message #2220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the new messsage field is cleaned after successfully sending a message its height changes, so the stored height needs to be updated. Otherwise when a keydown event is received again on the new message field the old height would be used for the calculations, which would cause the chat view to be wrongly scrolled after sending a message with several lines. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Looping through the last messages on arrow up/down may change the height of the new message field (as the last messages may contain different numbers of lines), so this needs to be done before handling height changes in the new message field for the chat view to be properly scrolled. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
When the chat view is resized the new messsage field height may change, so the stored height needs to be updated. Otherwise when a keydown event is received again on the new message field the old height would be used for the calculations, which would cause the chat view to be wrongly scrolled if a message is currently in the new message field and its height changed due to the resize. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: chat 💬
Member
Author
|
/backport to stable17 |
4 tasks
delete-merged-branch
bot
deleted the
fix-chat-jumping-back-when-typing-a-new-message
branch
|
backport to stable17 in #2222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1953
How to test
Scenario 1
Scenario 2
Scenario 3
Scenario 4
Result with this pull request
The chat is kept at the same scroll position.
Result without this pull request
The chat jumps back.