Fix setting again the same lobby state in the UI #2147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending a request to the server to set the same lobby state is valid, but unneeded. Moreover, the CallInfoView is rendered again only when the lobby state changes, so if the same state is set again a loading spinner will be shown instead of the radio button until something else changes in the room. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
fix-setting-again-the-same-lobby-state-in-the-ui
branch
from
8c901ec to
b1ed3c0
Compare
nickvergessen
approved these changes
Sep 2, 2019
delete-merged-branch
bot
deleted the
fix-setting-again-the-same-lobby-state-in-the-ui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug from #1926
Sending a request to the server to set the same lobby state is valid, but unneeded. Moreover, the
CallInfoViewis rendered again only when the lobby state changes, so if the same state is set again a loading spinner will be shown instead of the radio button until something else changes in the room.How to test (Scenario 1)
Result with this pull request
No request to set the lobby state is sent, and the radio button for All participants is not modified.
Result without this pull request
A request to set the lobby state is sent, and the radio button for All participants becomes a loading spinner.
How to test (Scenario 2)
Result with this pull request
The request to set the lobby state is not sent again, and the radio button for Moderators only is not modified.
Result without this pull request
Another request to set the lobby state is sent, and the radio button for Moderators only becomes a loading spinner.