Skip to content

Fix setting again the same lobby state in the UI #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ivansss merged 1 commit into from
Sep 2, 2019
Merged

Fix setting again the same lobby state in the UI #2147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix setting again the same lobby state in the UI 
Sending a request to the server to set the same lobby state is valid,
but unneeded. Moreover, the CallInfoView is rendered again only when the
lobby state changes, so if the same state is set again a loading spinner
will be shown instead of the radio button until something else changes
in the room.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Sep 2, 2019
commit b1ed3c02e00aeac6120df292cfc4924c44ec0e21
8 changes: 8 additions & 0 deletions js/views/callinfoview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,10 @@
},

setLobbyStateAllParticipants: function() {
if (this.model.get('lobbyState') === OCA.SpreedMe.app.LOBBY_NONE) {
return;
}

this.ui.allParticipantsRadio.prop('disabled', true);
this.ui.allParticipantsLabel.addClass('icon-loading-small');

Expand All @@ -338,6 +342,10 @@
},

setLobbyStateModeratorsOnly: function() {
if (this.model.get('lobbyState') === OCA.SpreedMe.app.LOBBY_NON_MODERATORS) {
return;
}

this.ui.moderatorsOnlyRadio.prop('disabled', true);
this.ui.moderatorsOnlyLabel.addClass('icon-loading-small');

Expand Down