Hide chat tab for folders #2605
Conversation
There was a problem hiding this comment.
nextcloud/server#18449 did not make it to beta 3 in server, so blocking merge of this pull request until the tarball of Talk for beta 3 is done.
Further changes are needed too for #2611 (besides just removing the placeholder message for folders).
|
Will merging this into master of talk break anything (problem) or will it just always show the tab (wouldnt mind)? |
It will probably break, as the constructor parameters changed (but I have not tested). |
I have tested with that branch checked out in the server @danxuliu |
Yes, what I mean is that it will break without that branch ;-) |
|
But isn't that in already? |
|
but it was merged after beta3, so if we want to have somethign working, we have to wait until beta3 compatible package has been built |
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Now the chat tab is not displayed for folders, so the placeholder that was shown in that case can be removed. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
bugfix/noid/hide-chat-tab-for-folders
branch
from
0f4d73a to
4bc3b69
Compare
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Rebased and adjusted to explicitly leave conversations when the chat tab can not be shown.
Based on nextcloud/server#18449
Signed-off-by: Marco Ambrosini [email protected]