Skip to content

Hide chat tab for folders #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoambrosini merged 3 commits into from
Jan 7, 2020
Merged

Hide chat tab for folders #2605

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
350f67c
Hide chat tab for folders
marcoambrosini Dec 19, 2019
7375900
Explicitly leave conversation when a chat tab is not displayed
danxuliu Jan 6, 2020
4bc3b69
Remove no longer needed placeholder
danxuliu Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove no longer needed placeholder 
Now the chat tab is not displayed for folders, so the placeholder that
was shown in that case can be removed.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Jan 6, 2020
commit 4bc3b69bed6e068bba2364f70d3b3219b7fd5946
6 changes: 1 addition & 5 deletions src/FilesSidebarTabApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,7 @@
-->
<template>
<div class="talkChatTab">
<div v-if="fileInfo && fileInfo.isDirectory()" class="emptycontent">
<div class="icon icon-talk" />
<h2>Conversations are not available for folders</h2>
</div>
<div v-else-if="isTalkSidebarSupportedForFile === undefined" class="emptycontent ui-not-ready-placeholder">
<div v-if="isTalkSidebarSupportedForFile === undefined" class="emptycontent ui-not-ready-placeholder">
<div class="icon icon-loading" />
</div>
<div v-else-if="!isTalkSidebarSupportedForFile" class="emptycontent file-not-shared">
Expand Down