User participants are identified by userId in the participant store, …

[nickvergessen]

…not by participant

Split from #3338 for faster merging

Not sure where participant comes from. I guess a copy paste fail.
userId is used in the rooms getParticipant:

spreed/lib/Controller/RoomController.php

Line 851 in 445756d

'userId' => (string) $userId,

And the calls getPeers:

spreed/lib/Controller/CallController.php

Line 66 in 06a045e

'userId' => $participant->getUser(),

The old Room API also had no participant key:

spreed/lib/Controller/RoomController.php

Line 338 in 445756d

'name' => $user->getDisplayName(),

This should explain and solve some of the "duplicate avatar" issues like #2913

[danxuliu]

Changing participant to userId in Participant.vue makes getParticipantIndex work. But... now userId is passed to promoteToModerator which expects the argument to be called participant instead.

I have not checked which other API calls expect participant besides the promoting/demoting ones, so there may be other issues lurking around, I do not know.

[nickvergessen]

Fixed it

[nickvergessen]

Also checked the others and the only other endpoint with "participant" was already getting it from the userId:

spreed/src/services/participantsService.js

Lines 104 to 108 in 2c6e88c

	const response = await axios.delete(generateOcsUrl('apps/spreed/api/v1', 2) + `room/${token}/participants`, {
	params: {
	participant: userId,
	},
	})

[danxuliu]

Tested and works 👍

If possible please squash all the commits in a single one before merging, as technically the last two are just fixups of the first one.