Skip to content

Die gracefully when user joins again in another tab/device #3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nickvergessen wants to merge 11 commits into from
Closed

Die gracefully when user joins again in another tab/device #3338

nickvergessen wants to merge 11 commits into from
+212 −22

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 16, 2020 •
edited
Loading

Steps

  1. In Tab 1 open a conversation as User A and join the call
  2. In Window 2 open the same conversation as User B and join the call
  3. In Tab 2 or Device 2 open the conversation as User 1 and leave it again
  4. 💥
  • Based on "409 Conflict" on joining a second time in the same conversation #3591
  • addParticipantOnce used a wrong check to see if a user already exists.
  • Internal signaling stops the signaling query and is just silent from there on in the old tab
  • External signaling is in limbo state and people joining later will get a different set of participants compared to users that were online all the time

@nickvergessen nickvergessen added 2. developing bug feature: api 🛠️ OCS API for conversations, chats and participants feature: signaling 📶 Internal and external signaling backends labels Apr 16, 2020
@nickvergessen nickvergessen added this to the 💚 Next Major (19) milestone Apr 16, 2020
@nickvergessen
Copy link
Member Author

nickvergessen commented Apr 16, 2020

Internal signaling

Bildschirmfoto von 2020-04-16 16-26-32

btw the OC.dialogs.confirmDestructive could really use a blurred/overlayed background as nothing should be done until it has been dealt with.

This was referenced Apr 22, 2020
Merged
Merged
Closed
@nickvergessen nickvergessen force-pushed the bugfix/noid/participant-collision-on-updates branch 2 times, most recently from aaa4e32 to 32efc49 Compare May 13, 2020 20:19
@nickvergessen
Optionally return 409 when trying to join a second time
289617f 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Also support guests to prevent breaking their sessions
1e6aeec 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Return session id, in call flag and last ping
09a1383 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Always ask if we can join if we are not reloading the page
836cbf9 
Note: This uses the browsers sessionStorage not the browserStorage.
As per https://stackoverflow.com/q/20325763 this is NOT shared between tabs.
For us this is the solution we were looking for, as it allows us to
identify if a user reloaded a conversation in the same tab,
or entered it in another tab.

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Ask for confirmation to join in case of session conflict
559fed2 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Automatically force join if the session is "old"
a34143c 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add documentation for the conflict handling
634b0f8 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen mentioned this pull request May 29, 2020
Merged
@nickvergessen
Leave the room with the old session
f9fbf87 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
fixup! Automatically force join if the session is "old"
c5f6744
@nickvergessen
Handle duplicated sessions more gracefully with the internal signaling
a9bc1b6 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Better handle 404 error as well as all other undefined scenarios
213a92a 
404: now redirects to /not-found
*: now retries after 10 seconds and shows an error
   and give up after 5 minutes recommending a reload

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the bugfix/noid/participant-collision-on-updates branch from 32efc49 to 213a92a Compare May 29, 2020 09:08
@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 15, 2020

Now merged into #3591

@nickvergessen nickvergessen deleted the bugfix/noid/participant-collision-on-updates branch June 15, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2. developing bug feature: api 🛠️ OCS API for conversations, chats and participants feature: signaling 📶 Internal and external signaling backends

Projects

None yet

Milestone

v10.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

2 participants

@nickvergessen