Fix internal signaling status code detection #3383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
bug
feature: signaling 📶
danxuliu
approved these changes
Apr 23, 2020
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
I could not reproduce the issue described in the PR description 🤷 If I navigate away (as I understand it that means changing to a different conversation) the pulling for the previous conversation was stopped as expected.
Anyway, this fixes the catch clause syntax (it was a leftover from the move from jQuery.ajax() to axios calls) and fixes other scenarios (like trying to pull messages again when kicked from a conversation), so 👍
Signed-off-by: Joas Schilling <[email protected]>
CancelableRequest creates a cancel token that is passed to the wrapped axios request in its options. "pullSignalingMessages" did not accept an "options" parameter, so the cancel token was ignored by the request and cancelling it had no effect. Besides that, when the pull signaling messages request is cancelled nothing needs to be done in its handler. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/internal-signaling-error-handling
branch
from
4deb8cd to
6d15717
Compare
Member
Author
|
/backport to stable18 |
|
backport to stable18 in #3405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #3338 for faster merging
When you navigated away, the signaling is currently not stopped, but does something else.
But because the 404 detection failed as well, we retried signaling 3 more times before stopping.