Skip to content

"409 Conflict" on joining a second time in the same conversation #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 22 commits into from
Jul 1, 2020
Merged

"409 Conflict" on joining a second time in the same conversation #3591

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f5198c0
Optionally return 409 when trying to join a second time
nickvergessen May 15, 2020
5e6a21b
Also support guests to prevent breaking their sessions
nickvergessen May 15, 2020
d5c42d8
Return session id, in call flag and last ping
nickvergessen May 15, 2020
9db6853
Always ask if we can join if we are not reloading the page
nickvergessen May 29, 2020
6b36032
Ask for confirmation to join in case of session conflict
nickvergessen May 29, 2020
cd81c6e
Automatically force join if the session is "old"
nickvergessen May 29, 2020
da78e4c
Add documentation for the conflict handling
nickvergessen May 29, 2020
5bce99b
Leave the room with the old session
nickvergessen May 29, 2020
ee2632b
Further pass on the sessionId to leaveRoomAsParticipant
nickvergessen Jun 15, 2020
61134a0
Handle duplicated sessions more gracefully with the internal signaling
nickvergessen Apr 16, 2020
dd48b52
Better handle 404 error as well as all other undefined scenarios
nickvergessen Apr 16, 2020
9fc01a6
Show session conflict warning when a session joins again for your own…
nickvergessen Jun 15, 2020
9775215
Redirect to a plain page to avoid reconnections
nickvergessen Jun 16, 2020
237d2f5
Send a signal to disconnect the old session before killing it
nickvergessen Jun 16, 2020
5f83e23
Don't show call state when asking to kill the other session
nickvergessen Jun 16, 2020
389d7b6
Trigger a vue event when SessionStorage "joined_conversation" changes
nickvergessen Jun 24, 2020
d54249f
Don't kill the previous session when we navigate away
nickvergessen Jun 24, 2020
eba73a3
Handle the disinvite event properly when the session was kicked
nickvergessen Jun 24, 2020
0f2176b
Add a hack to check if the dialog was closed via the X
nickvergessen Jun 29, 2020
1efead6
If the user has no participant anymore, it was not a conflict
nickvergessen Jun 29, 2020
0c729f0
Fix mixin state also when the component is loaded after the state alr…
nickvergessen Jun 30, 2020
e5c75cb
Update the session and the call flag when force joining
nickvergessen Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle the disinvite event properly when the session was kicked 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Jul 1, 2020
commit eba73a3950c546bea7d47ede695dc030d55c72ad
15 changes: 13 additions & 2 deletions src/utils/signaling.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,8 +1120,19 @@ Signaling.Standalone.prototype.processRoomMessageEvent = function(data) {
}

Signaling.Standalone.prototype.processRoomListEvent = function(data) {
console.debug('Room list event', data)
EventBus.$emit('shouldRefreshConversations')
switch (data.event.type) {
case 'disinvite':
if (data.event.disinvite.roomid === this.currentRoomToken) {
console.error('User or session was removed from the conversation, redirecting')
EventBus.$emit('duplicateSessionDetected')
break
}
// eslint-disable-next-line no-fallthrough
default:
console.debug('Room list event', data)
EventBus.$emit('shouldRefreshConversations')
break
}
}

Signaling.Standalone.prototype.processRoomParticipantsEvent = function(data) {
Expand Down