Skip to content

Warn user on high load #3839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 19 commits into from
Jul 13, 2020
Merged

Warn user on high load #3839

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c7d8a73
Add analyzer for the quality of peer connections
danxuliu Jun 22, 2020
860ed63
Take round trip time into account when calculating the quality
danxuliu Jul 7, 2020
4bc4da7
Trigger events when the quality changes
danxuliu Jun 22, 2020
c64b16b
Make possible to enable and disable the analysis of audio or video
danxuliu Jul 3, 2020
4a431f1
Guard against null screen peer
danxuliu Jul 2, 2020
efb653a
Move peer and screenPeer to attributes in CallParticipantModel
danxuliu Jul 3, 2020
74f59d7
Add peer and screenPeer attributes to LocalCallParticipantModel
danxuliu Jul 3, 2020
697cd88
Add analyzer for participants
danxuliu Jul 3, 2020
a93c32b
Add analyzer for calls
danxuliu Jul 3, 2020
111d700
Show warning when the quality of the connection is bad
danxuliu Jul 3, 2020
48ad037
Add a grace period before hiding the quality warning
danxuliu Jul 3, 2020
56f743f
Show tooltip only if the quality warning has not been recently shown
danxuliu Jul 3, 2020
2bf307f
Take video and screen quality into account in the quality warning
danxuliu Jul 6, 2020
fcfe74c
Move setting class attributes to its own method
danxuliu Jul 9, 2020
363ecb0
Dimm own avatar and video when the sender connection quality is bad
danxuliu Jul 9, 2020
92d7ea5
Split tooltips for audio, video and screen quality
danxuliu Jul 9, 2020
b92a161
Replace quality warning with tooltips on the local media buttons
danxuliu Jul 9, 2020
699a4a5
Increase grace period for quality tooltip
danxuliu Jul 9, 2020
3b78a93
Show warning on the button that could solve the issue
danxuliu Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a grace period before hiding the quality warning 
If the quality was seen as very bad for a split second this showed and
quickly hidden again the quality warning, which is annoying as it may
not be possible to even read the tooltip. To mitigate that now the
quality warning is shown at least for 3 seconds before hiding it again.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Jul 13, 2020
commit 48ad037918b115359db5da383065673d6abddb06
19 changes: 19 additions & 0 deletions src/components/CallView/shared/LocalVideo.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ export default {
data() {
return {
callAnalyzer: callAnalyzer,
qualityWarningInGracePeriodTimeout: null,
}
},

Expand Down Expand Up @@ -154,6 +155,10 @@ export default {
},

showQualityWarning() {
return this.senderConnectionQualityAudioIsBad || this.qualityWarningInGracePeriodTimeout
},

senderConnectionQualityAudioIsBad() {
return callAnalyzer
&& (callAnalyzer.attributes.senderConnectionQualityAudio === CONNECTION_QUALITY.VERY_BAD
|| callAnalyzer.attributes.senderConnectionQualityAudio === CONNECTION_QUALITY.NO_TRANSMITTED_DATA)
Expand Down Expand Up @@ -206,6 +211,20 @@ export default {
this._setLocalStream(localStream)
},

senderConnectionQualityAudioIsBad: function(senderConnectionQualityAudioIsBad) {
if (!senderConnectionQualityAudioIsBad) {
return
}

if (this.qualityWarningInGracePeriodTimeout) {
window.clearTimeout(this.qualityWarningInGracePeriodTimeout)
}

this.qualityWarningInGracePeriodTimeout = window.setTimeout(() => {
this.qualityWarningInGracePeriodTimeout = null
}, 3000)
},

},

mounted() {
Expand Down