[stable19] Warn user on high load #3898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
A high round trip time means that there is a delay in the connection, which is in itself bad (specially in a conversation instead of in a "monologue"). Besides that a delay in the connection can also cause that some packets, even if they are not lost, are discarded anyway to try to keep the playing rate in real time. The round trip time is only available for sent data, but not received data. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Currently "setScreenPeer" is only called with actual objects, never null, but just in case for the future. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
This will allow to get those attributes from other objects, as well as trigger an event when they are changed. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
If the quality was seen as very bad for a split second this showed and quickly hidden again the quality warning, which is annoying as it may not be possible to even read the tooltip. To mitigate that now the quality warning is shown at least for 3 seconds before hiding it again. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
In some cases the warning could be repeteadly shown and hidden again. In those cases showing the warning is fine, but showing the tooltip could be annoying. Therefore now the tooltip is automatically shown only if the warning has not been recently shown. In any case, the tooltip can still be shown when hovering on the warning. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The dimming amount is the same used when a participant is disconnected, although in that case there will be also a loading spinner which is not shown here. The dimming is meant to replace the warning icon as a way to make the user aware of an issue with the connection when the tooltip is hidden, so an ARIA label is provided too. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Now the warning about the connection quality is directly shown on the buttons that enable/disable audio, video and screen instead of on a different, disconnected element. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Before the warning tooltip about a bad connection quality was shown on
the button for the media that had the issue. Now the tooltip is shown
instead on the button for the media that could solve the issue. So, for
example, "Audio is bad, disable your video" before was shown on the
audio button, but now it is shown in the video button.
If only one type of media is being transmitted then the tooltip is shown
on the button for that media ("so "Audio is bad" is shown in the audio
button, as it is just an information but there is nothing that can be
done about it).
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
backportbot-nextcloud
bot
added
enhancement
feature: call 📹
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #3839