Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1a09ea7
Add analyzer for the quality of peer connections
danxuliu Jun 22, 2020
5c45e23
Take round trip time into account when calculating the quality
danxuliu Jul 7, 2020
949f10a
Trigger events when the quality changes
danxuliu Jun 22, 2020
e2aa17d
Make possible to enable and disable the analysis of audio or video
danxuliu Jul 3, 2020
97e12ca
Guard against null screen peer
danxuliu Jul 2, 2020
a205ca4
Move peer and screenPeer to attributes in CallParticipantModel
danxuliu Jul 3, 2020
790c981
Add peer and screenPeer attributes to LocalCallParticipantModel
danxuliu Jul 3, 2020
ca4fdd1
Add analyzer for participants
danxuliu Jul 3, 2020
b5e724e
Add analyzer for calls
danxuliu Jul 3, 2020
58fc1f5
Show warning when the quality of the connection is bad
danxuliu Jul 3, 2020
d4ec4d9
Add a grace period before hiding the quality warning
danxuliu Jul 3, 2020
581d68a
Show tooltip only if the quality warning has not been recently shown
danxuliu Jul 3, 2020
6cb8de5
Take video and screen quality into account in the quality warning
danxuliu Jul 6, 2020
ffe3cf6
Move setting class attributes to its own method
danxuliu Jul 9, 2020
a6b897a
Increase grace period for quality tooltip
danxuliu Jul 9, 2020
087330b
Fix duplicated event listeners in ParticipantAnalyzer
danxuliu Jul 16, 2020
ad27de1
Dedicated connection warning icon
nickvergessen Jul 15, 2020
e12ca19
Add buttons to disable video and screen share to quality warning tooltip
Jul 17, 2020
1bff844
Add button to explicitly dismiss the quality warning tooltip
Jul 17, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Show tooltip only if the quality warning has not been recently shown
In some cases the warning could be repeteadly shown and hidden again. In
those cases showing the warning is fine, but showing the tooltip could
be annoying. Therefore now the tooltip is automatically shown only if
the warning has not been recently shown. In any case, the tooltip can
still be shown when hovering on the warning.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
danxuliu committed Jul 21, 2020
commit 581d68aca07fc7edd534676b9bf65cc7071b8656
25 changes: 24 additions & 1 deletion src/components/CallView/LocalVideo.vue
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ export default {
return {
callAnalyzer: callAnalyzer,
qualityWarningInGracePeriodTimeout: null,
qualityWarningWasRecentlyShownTimeout: null,
}
},

Expand Down Expand Up @@ -146,6 +147,14 @@ export default {
return t('spreed', 'Bad sent audio quality')
},

// The quality warning tooltip is automatically shown only if the
// quality warning has not been shown in the last minute. Otherwise the
// tooltip is hidden even if the warning is shown, although the tooltip
// can be shown anyway by hovering on the warning.
showQualityWarningTooltip() {
return !this.qualityWarningWasRecentlyShownTimeout
},

qualityWarningTooltip() {
if (!this.showQualityWarning) {
return false
Expand All @@ -164,7 +173,7 @@ export default {

return {
content: message,
show: true,
show: this.showQualityWarningTooltip,
}
},
},
Expand Down Expand Up @@ -200,6 +209,20 @@ export default {
}, 3000)
},

showQualityWarning: function(showQualityWarning) {
if (showQualityWarning) {
return
}

if (this.qualityWarningWasRecentlyShownTimeout) {
window.clearTimeout(this.qualityWarningWasRecentlyShownTimeout)
}

this.qualityWarningWasRecentlyShownTimeout = window.setTimeout(() => {
this.qualityWarningWasRecentlyShownTimeout = null
}, 60000)
},

},

mounted() {
Expand Down