[stable18] Warn user on high load #3899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
added
3. to review
enhancement
feature: frontend 🖌️
danxuliu
force-pushed
the
backport/3839/stable18-warn-user-on-high-load
branch
from
431c98d to
a53dd1f
Compare
1 task
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
A high round trip time means that there is a delay in the connection, which is in itself bad (specially in a conversation instead of in a "monologue"). Besides that a delay in the connection can also cause that some packets, even if they are not lost, are discarded anyway to try to keep the playing rate in real time. The round trip time is only available for sent data, but not received data. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Currently "setScreenPeer" is only called with actual objects, never null, but just in case for the future. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
This will allow to get those attributes from other objects, as well as trigger an event when they are changed. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
If the quality was seen as very bad for a split second this showed and quickly hidden again the quality warning, which is annoying as it may not be possible to even read the tooltip. To mitigate that now the quality warning is shown at least for 3 seconds before hiding it again. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
In some cases the warning could be repeteadly shown and hidden again. In those cases showing the warning is fine, but showing the tooltip could be annoying. Therefore now the tooltip is automatically shown only if the warning has not been recently shown. In any case, the tooltip can still be shown when hovering on the warning. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The event listeners where not properly stopped when a Peer was set, so if the same Peer was set twice the listeners were duplicated, which in turn could lead to errors due to only one of them being removed. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Instead of showing the quality warning tooltip only if it has not been recently shown now the quality warning tooltip is always shown when the quality warning is shown, except if the user has explicitly dismissed it. Signed-off-by: Marco Ambrosini <[email protected]>
danxuliu
force-pushed
the
backport/3839/stable18-warn-user-on-high-load
branch
from
a53dd1f to
1bff844
Compare
nickvergessen
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #3926
Backport of #3839, #3911 and #3907