Skip to content

Make sure the avatar/video are not transparently overlaying in one-to… #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nickvergessen wants to merge 1 commit into from
Closed

Make sure the avatar/video are not transparently overlaying in one-to… #3906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/components/CallView/shared/LocalVideo.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,9 +411,14 @@ export default {
}

.bad-connection-quality {
/* This adds black bars around the video depending on the resolution,
* but it's still better than having your half-transparent avatar
* shine an underlying video/avatar through it. */
background-color: #000000;

.video,
.avatar-container {
opacity: 0.5
opacity: 0.3
Copy link
Member

@danxuliu danxuliu Jul 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep opacity to 0.5, as that value was set for consistency with the opacity of remote videos during an ICE disconnection.

}
}

Expand Down