Make sure the avatar/video are not transparently overlaying in one-to… #3906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-one calls This adds black bars around the video depending on the resolution, but it's still better than having your half-transparent avatar shine an underlying video/avatar through it. Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
bug
feature: frontend 🖌️
Member
Author
|
/backport to stable19 |
danxuliu
reviewed
Jul 15, 2020
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Personally I prefer a transparent avatar/video during bad connections in two participant calls than always having black bars around the video 🤷
| .video, | ||
| .avatar-container { | ||
| opacity: 0.5 | ||
| opacity: 0.3 |
Member
There was a problem hiding this comment.
I would keep opacity to 0.5, as that value was set for consistency with the opacity of remote videos during an ICE disconnection.
marcoambrosini
previously approved these changes
Jul 20, 2020
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
So now when there's a bad connection we have:
- A popover that warns the user and stays on top of your video until you dismiss it or click the suggested action;
- A persistent icon that when hovered shows you the popover with the warning even after dismissal;
I think that the combination of these two is plenty enough of a warning and there's no need to lower the opacity of the video at all, don't you think?
Member
|
Closed in favour of #3907. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-one calls
This adds black bars around the video depending on the resolution,
but it's still better than having your half-transparent avatar
shine an underlying video/avatar through it.
As per #3905