[stable18] Do not reuse media constraints between independent media requests #3926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
When getting the user media for the first time both audio and video are requested. If video is not available then the user media is got again requesting only audio. However, as the media constraints were reused in any following user media request as soon as video failed once it was never requested again. Therefore if a camera was plugged in later it was ignored until Talk was restarted. Now getting the user media always tries first with both audio and video and then fallbacks to trying only with audio, even if video was not available in a previous request. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The error is shown only if there was an actual error when getting the video; it is not shown if there is simply no camera, or if neither audio nor video could be got (as there was already a different toast in place in that case). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
nickvergessen
approved these changes
Jul 21, 2020
nickvergessen
deleted the
backport/3912/stable18-do-not-reuse-media-constraints-between-independent-media-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3912