Fix MediaDevicesSelector not updated when mounted #4038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The watcher that updated the selected option based on the "deviceId" passed to the component was not executed when the component was mounted, so it was undefined until something else modified that device ID. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
nickvergessen
approved these changes
Aug 24, 2020
nickvergessen
deleted the
fix-mediadevicesselector-not-updated-when-mounted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4032
The watcher that updated the selected option based on the
deviceIdpassed to the component was not executed when the component was mounted, so it was undefined until something else modified that device ID.This was not noticeable when the MediaDevicesPreview was shown in the sidebar, as in that case it was mounted once when the UI was loaded and never destroyed, but once moved to the SettingsDialog the component is created and destroyed whenever the dialog is open or closed.
How to test
Result with this pull request
The same devices that were selected before closing the dialog will be selected once it is opened again.
Result without this pull request
There will be no devices selected.