Skip to content

Fix MediaDevicesSelector not updated when mounted #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Aug 24, 2020
Merged

Fix MediaDevicesSelector not updated when mounted #4038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/components/MediaDevicesSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,18 @@ export default {
},

watch: {
deviceSelectedOptionFromDeviceId(deviceSelectedOptionFromDeviceId) {
this.deviceSelectedOption = deviceSelectedOptionFromDeviceId
// The watcher needs to be set as "immediate" to ensure that
// "deviceSelectedOption" will be set when mounted.
deviceSelectedOptionFromDeviceId: {
handler(deviceSelectedOptionFromDeviceId) {
this.deviceSelectedOption = deviceSelectedOptionFromDeviceId
},
immediate: true,
},

// The watcher should not be set as "immediate" to prevent
// "update:deviceId" from being emitted when mounted with the same value
// initially passed to the component.
deviceSelectedOption(deviceSelectedOption) {
if (deviceSelectedOption && deviceSelectedOption.id === null) {
this.$emit('update:deviceId', null)
Expand Down