Add a default on NotNull column #4127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
danxuliu
approved these changes
Sep 9, 2020
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Tested (although not with Oracle 🤷) and works 👍
danxuliu
deleted the
bugfix/noid/fix-updating-over-notnull-default-column
branch
This was referenced Sep 9, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref nextcloud/server#22643
Since we always set it to
'0'anyway, this is only an issue when updating from a previous version on Oracle. Since it didn't install, that is a non issue and we don't need to update the default on current versions.