Remember grid view state per call #4451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default to grid mode in group and public calls and to speaker mode in one on one conversations. Signed-off-by: Vincent Petry <[email protected]>
PVince81
force-pushed
the
feature/3824/remember-grid-state
branch
from
cf49d1a to
bf682ac
Compare
Member
Author
|
@nickvergessen the default for group or public conversation is now grid. (I saw other places in the code where public was also considered a group conversation) I've also adjusted the implementation to store the preference as soon as it's changed instead of upon leaving the call: because when leaving the call by closing the browser window it doesn't call that handler. Please re-review |
jancborchardt
approved these changes
Nov 2, 2020
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Nice improvement! :) 👍 UX-wise, didn’t test
marcoambrosini
approved these changes
Nov 2, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3824
Please note that joinCall and leaveCall are actions already defined in the participantsStore.
Nevertheless, vuex will call the action on both the stores! 😄