Fix remembered grid state per call #4542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BrowserStorage returns a string, but isGrid is expected to be a boolean, so both "true" and "false" were truthy values. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The conversation type was not checked against the right constants. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
2. developing
bug
feature: frontend 🖌️
Member
PVince81
approved these changes
Nov 5, 2020
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 let's merge this, the change makes sense!
Member
|
seems I also missed that CONVERSATION constant thing, nice find |
1 task
Member
Author
Ah, sorry, I missed it. Ok, let's merge this now so you can rebase; I will fix the sidebar thing in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4451